fix(ui)!: default empty Template wrappers to div - #242
Merged
Conversation
linkdata
force-pushed
the
fix/template-default-wrapper
branch
from
August 7, 2026 05:43
8016032 to
1a7b1bf
Compare
Keep RequestWriter.Register as the template-authored DOM escape hatch while removing the exported Register and NewRegister adapter API.
linkdata
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewTemplateandRequestWriter.Templatewrapper tags todivwhile keepingHandlerwhole-page rendering unwrapped{{template ...}}inclusion for unwrapped structural fragmentsRequestWriter.Registeras the escape hatch for template-authored DOM while removing the exportedui.Registerandui.NewRegisteradapter APIBreaking changes
NewTemplate("", ...)andRequestWriter.Template("", ...)now generate adivwrapper instead of rendering unwrappedui.Registerandui.NewRegisterare removed; useRequestWriter.Registerfor template-authored elements or implement a completejaws.UIVerification
go generate ./...go vet ./...gofmt -l .staticcheck ./...golangci-lint rungosec ./...JAWS_REQUIRE_NODE=1 go test -race -coverprofile=... ./...JAWS_REQUIRE_NODE=1 go test ./...go build ./...lib/bindtest binary cross-compileCloses #236