Add filter_effects crate - #174
Open
PoignardAzur wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
I've taken the liberty to already namesquat |
PoignardAzur
marked this pull request as draft
August 26, 2026 12:35
PoignardAzur
marked this pull request as ready for review
August 26, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a vocabulary crate that defines standard SVG filter effects and... that's it.
It deliberately doesn't include any code for processing filter effects (that's left to Vello) or building filter graphs (that's left to Vello and/or a future vocabulary crate).
Most of this code is adapted from https://github.com/linebender/vello/blob/f6d62826a97ad59b1485126fb87b35b3a85f6528/sparse_strips/vello_common/src/filter_effects.rs, especially the
FilterPrimitiveenum.Documentation draws heavily from the https://drafts.csswg.org/filter-effects spec.
None of this code was AI-generated, but there's been a lot of copy-pasting, so I might have missed something.