Guard against access outside of UFO root. - #413
Merged
Merged
Conversation
This is interesting because in some cases a UFO can have a feature file that has include statements pointing to a parent directory, and that _is_ an interesting edge case to consider; however this patch is specifically concerned with handling the image/ and data/ directories, where we can unambiguously reject these paths.
RickyDaMa
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little issue that surfaced in the course of the other load/save changes: the new API would let the user include
..in a path for an image or data resource, which we don't want.This is interesting because in some cases a UFO can have a feature file that has include statements pointing to a parent directory, and that is an interesting edge case to consider; however this patch is specifically concerned with handling the image/ and data/ directories, where we can unambiguously reject these paths.