Add verticalOrigin accessor method - #409
Merged
Merged
Conversation
Contributor
|
(This repo felt like a nice home as the lib key is very well-defined in the spec 🏡 When this lands, there are a few projects downstream that can simplify too too, e.g. the utility function I added to ufo2fontir in fontc can go) |
RickyDaMa
reviewed
Jun 9, 2026
RickyDaMa
reviewed
Jun 12, 2026
Co-authored-by: Harry Dalton <harry.dalton@daltonmaag.com>
cmyr
approved these changes
Jun 12, 2026
cmyr
left a comment
cmyr
left a comment
Member
There was a problem hiding this comment.
sure if you think this would be useful? Is there a particular reason this would be useful for verticalOrigin but not horizontal?
left some notes inline but i'm not opposed
And use simpler float detection
Collaborator
Author
The horizontal origin is always zero I think 😁 |
RickyDaMa
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We thought we could have an official accessor for a glyph's vertical origin. Feel free to code golf this.
Harry helped flesh this out :)