fix(NO-TASK): Remove unused Composer install from Release workflow - #38
Merged
Conversation
release-please only reads git history and release-please-config.json, so it never needed the PHP dependencies. The step also started failing outright once phpunit/phpunit ^13 landed: this job has no setup-php step, so it runs on the runner's system PHP 8.3.6, and PHPUnit 13 requires PHP >= 8.4.1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The shared linchpin/actions update-readme workflow generates a plugin/theme table from composer.lock. This repo is a phpcs standards library: composer.lock is gitignored and the README has no generated table, so the job was a no-op. As of @v4 it is worse than a no-op -- it runs `git add README.md composer.lock` without checking that the lock file is tracked, so it exits 128 on every push. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Releaseworkflow has been failing onmainsincephpunit/phpunit ^13landed (#23):ci.ymlsets up PHP viashivammathur/setup-php@v2withphp-version: latest, so it is unaffected.release-please.ymlhas no such step, soramsey/composer-installruns against the runner's system PHP (8.3.6) and now fails.Fix
Drop the
Install Composer dependenciesstep.release-please-actionis a Node action that only reads git history andrelease-please-config.json— it never needed the PHP dependencies. This also makes the job faster.Adding
setup-phpinstead would work too, but keeping a Composer install that nothing consumes is just a standing liability.Note
The
update-readmejob in this same workflow is failing separately and is not addressed here — see the discussion on that; it needs a decision aboutlinchpin/actions@v4.🤖 Generated with Claude Code