chore: Sync account schemas#692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-openapi studio · code · diff
✅ grid-ruby studio · code · diff
✅ grid-go studio · code · diff
✅ grid-kotlin studio · code · diff
✅ grid-python studio · code · diff
✅ grid-php studio · code · diff
✅ grid-cli studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis auto-synced PR adds an optional
Confidence Score: 4/5Safe to merge after correcting the PHP rail field description and example, which currently reference Indian payment systems instead of Philippine ones. The PHP openapi/components/schemas/common/PhpAccountInfoBase.yaml — the rail field description and example need to reference Philippine payment rails, not Indian ones
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/PhpAccountInfoBase.yaml | Adds optional rail field for routing PHP payouts, but description and example reference Indian payment rails (NEFT/RTGS for INR) instead of Philippine ones (PESONet/InstaPay) |
| openapi/components/schemas/common/GtqAccountInfoBase.yaml | Minor wording update: bankName description changed from "The name of the beneficiary's bank" to "The name of the bank" |
| openapi.yaml | Generated bundle updated to reflect both the PHP rail field addition (with INR example issue) and GTQ bankName wording change |
| mintlify/openapi.yaml | Mintlify-specific generated bundle updated identically to openapi.yaml — carries the same INR example issue in the PHP rail field |
Sequence Diagram
%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
participant Client
participant GridAPI
participant PHPRail as PHP Payment Rail (PESONet / InstaPay)
participant INRRail as INR Payment Rail (NEFT / RTGS)
Client->>GridAPI: "POST /payouts { accountType: PHP_ACCOUNT, rail: PESONet }"
GridAPI->>PHPRail: Route payout over PESONet
PHPRail-->>GridAPI: Confirmation
GridAPI-->>Client: Success
Note over Client,INRRail: Current description/example says NEFT/RTGS (INR rails) - misleading PHP integrators
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
participant Client
participant GridAPI
participant PHPRail as PHP Payment Rail (PESONet / InstaPay)
participant INRRail as INR Payment Rail (NEFT / RTGS)
Client->>GridAPI: "POST /payouts { accountType: PHP_ACCOUNT, rail: PESONet }"
GridAPI->>PHPRail: Route payout over PESONet
PHPRail-->>GridAPI: Confirmation
GridAPI-->>Client: Success
Note over Client,INRRail: Current description/example says NEFT/RTGS (INR rails) - misleading PHP integrators
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
openapi/components/schemas/common/PhpAccountInfoBase.yaml:24-35
The `rail` field description and example are copied verbatim from `InrAccountInfoBase.yaml` and reference Indian payment rails (NEFT, RTGS) rather than Philippine ones. A developer integrating PHP payouts will see "e.g. NEFT or RTGS for INR" and the example value `NEFT`, both of which are specific to India's NEFT/RTGS interbank clearing systems. The description and example should reflect the actual Philippine payment rails (e.g., PESONet or InstaPay).
```suggestion
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. PESONet or InstaPay for PHP).
example: PESONet
minLength: 1
maxLength: 32
example:
accountType: PHP_ACCOUNT
bankName: BDO Unibank
accountNumber: '001234567890'
rail: PESONet
```
Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| rail: | ||
| type: string | ||
| description: The payment rail to route the payout over, for currencies that support | ||
| more than one (e.g. NEFT or RTGS for INR). | ||
| example: NEFT | ||
| minLength: 1 | ||
| maxLength: 32 | ||
| example: | ||
| accountType: PHP_ACCOUNT | ||
| bankName: BDO Unibank | ||
| accountNumber: '001234567890' | ||
| rail: NEFT |
There was a problem hiding this comment.
rail field description and example are copied verbatim from InrAccountInfoBase.yaml and reference Indian payment rails (NEFT, RTGS) rather than Philippine ones. A developer integrating PHP payouts will see "e.g. NEFT or RTGS for INR" and the example value NEFT, both of which are specific to India's NEFT/RTGS interbank clearing systems. The description and example should reflect the actual Philippine payment rails (e.g., PESONet or InstaPay).
| rail: | |
| type: string | |
| description: The payment rail to route the payout over, for currencies that support | |
| more than one (e.g. NEFT or RTGS for INR). | |
| example: NEFT | |
| minLength: 1 | |
| maxLength: 32 | |
| example: | |
| accountType: PHP_ACCOUNT | |
| bankName: BDO Unibank | |
| accountNumber: '001234567890' | |
| rail: NEFT | |
| rail: | |
| type: string | |
| description: The payment rail to route the payout over, for currencies that support | |
| more than one (e.g. PESONet or InstaPay for PHP). | |
| example: PESONet | |
| minLength: 1 | |
| maxLength: 32 | |
| example: | |
| accountType: PHP_ACCOUNT | |
| bankName: BDO Unibank | |
| accountNumber: '001234567890' | |
| rail: PESONet |
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfoBase.yaml
Line: 24-35
Comment:
The `rail` field description and example are copied verbatim from `InrAccountInfoBase.yaml` and reference Indian payment rails (NEFT, RTGS) rather than Philippine ones. A developer integrating PHP payouts will see "e.g. NEFT or RTGS for INR" and the example value `NEFT`, both of which are specific to India's NEFT/RTGS interbank clearing systems. The description and example should reflect the actual Philippine payment rails (e.g., PESONet or InstaPay).
```suggestion
rail:
type: string
description: The payment rail to route the payout over, for currencies that support
more than one (e.g. PESONet or InstaPay for PHP).
example: PESONet
minLength: 1
maxLength: 32
example:
accountType: PHP_ACCOUNT
bankName: BDO Unibank
accountNumber: '001234567890'
rail: PESONet
```
How can I resolve this? If you propose a fix, please make it concise.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.