Skip to content

Develop to gloas - #879

Merged
vgorkavenko merged 5 commits into
gloasfrom
develop-to-gloas
Sep 4, 2026
Merged

Develop to gloas#879
vgorkavenko merged 5 commits into
gloasfrom
develop-to-gloas

Conversation

@vgorkavenko

Copy link
Copy Markdown
Contributor

Description

TBD

Checklist

  • Appropriate PR labels applied
  • Test coverage maintained (just coverage)
    • No need to add/update tests
    • Tests are added/updated
  • Documentation maintained
    • No need to update
    • Updated

madlabman and others added 5 commits August 18, 2026 19:48
## Description

Scenario/integration tests for CSM 0x02

## Checklist

- [ ] Appropriate PR labels applied
- [ ] Test coverage maintained (`just coverage`)
  - [ ] No need to add/update tests
  - [ ] Tests are added/updated
- [ ] Documentation maintained
  - [ ] No need to update
  - [ ] Updated
## Description

CSM 0x02 on hoodi deploy artifacts.

## Checklist

- [x] Appropriate PR labels applied
- [x] Test coverage maintained (`just coverage`)
  - [x] No need to add/update tests
  - [ ] Tests are added/updated
- [x] Documentation maintained
  - [x] No need to update
  - [ ] Updated
@vgorkavenko
vgorkavenko requested a review from a team as a code owner September 4, 2026 09:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T09:57:19.811533Z a312b3e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vgorkavenko
vgorkavenko changed the base branch from develop to gloas September 4, 2026 09:53
@vgorkavenko
vgorkavenko requested a review from a team as a code owner September 4, 2026 09:53
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

/// @param data @see ProcessWithdrawalInput
function processHistoricalWithdrawalProof(ProcessWithdrawalInput calldata data) external;

P2 Badge Regenerate docs after changing the Verifier ABI

The generated API documentation was not updated and still advertises ProcessHistoricalWithdrawalInput, the old recent-proof input shape, and removed getters such as WITHDRAWAL_ADDRESS. Consumers following docs/src will therefore encode calls against an ABI that this interface no longer implements; run forge doc and commit the regenerated output with this ABI change.

AGENTS.md reference: AGENTS.md:L12-L15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vgorkavenko
vgorkavenko merged commit a312b3e into gloas Sep 4, 2026
5 of 6 checks passed
@vgorkavenko
vgorkavenko deleted the develop-to-gloas branch September 4, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants