Skip to content

feat: compensate penalty by owner - #875

Merged
vgorkavenko merged 3 commits into
phase-2from
feat/only-owner
Sep 2, 2026
Merged

feat: compensate penalty by owner#875
vgorkavenko merged 3 commits into
phase-2from
feat/only-owner

Conversation

@vgorkavenko

Copy link
Copy Markdown
Contributor

Description

Only owner should be able to compensate general delayed penalty from bond balance

Checklist

  • Appropriate PR labels applied
  • Test coverage maintained (just coverage)
    • Tests are added/updated
  • Documentation maintained
    • No need to update

@vgorkavenko
vgorkavenko requested a review from a team as a code owner September 2, 2026 11:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T12:52:36.065209Z 6ee392f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 375c78a48a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/abstract/BaseModule.sol

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ee392f6fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


/// @notice Compensate general delayed penalty (locked bond) for the given Node Operator from Node Operator's bond
/// @dev Can only be called by the Node Operator manager
/// @dev Can only be called by the Node Operator owner

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate docs after changing the authorization NatSpec

The fresh interface edit fixes the source NatSpec, but the tracked generated pages docs/src/src/interfaces/IBaseModule.sol/interface.IBaseModule.md and docs/src/src/abstract/BaseModule.sol/abstract.BaseModule.md still state that only the manager may call this function. Integrators reading the published/generated API documentation will therefore use the wrong caller for operators without extended permissions; run forge doc and commit the updated output.

AGENTS.md reference: AGENTS.md:L12-L15

Useful? React with 👍 / 👎.

@vgorkavenko
vgorkavenko merged commit 7e4b902 into phase-2 Sep 2, 2026
6 checks passed
@vgorkavenko
vgorkavenko deleted the feat/only-owner branch September 2, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants