feat(providers): add Apertis preset - #812
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Ingwannu
left a comment
There was a problem hiding this comment.
The preset itself is potentially valuable and the implementation gets several important details right: fixed Bearer-authenticated /v1/models, openai-chat, liveModels, and preserveCustomDestination all match the intended registry contract. It is not mergeable yet for two concrete reasons:
- This branch is stale against current
dev. The docs change the catalog total to 61, while currentdevalready has 65 presets (54 key-based); Apertis would make that 66/55. The branch also conflicts in all five provider docs,registry.ts, the icon table, and registry parity because newer presets such as DeepInfra, Hyperbolic, and Volcengine landed after its base. Please rebase onto currentdev, preserve every existing entry, and regenerate the counts/parity expectation. - A canonical aggregator preset is a credential-destination change. The PR explicitly says provider-specific routing/resale authorization is non-public. The public product-page claim is not enough to independently verify the policy requirement. Please provide the contractual authorization confidentially to the project owner/maintainers and record only the maintainer verification outcome/date in the PR; do not post confidential terms or credentials here. If that evidence cannot be shared, the acceptable fallback is an inert free-directory row rather than a canonical registry entry.
Keep this draft until both points are resolved. After the rebase, rerun the focused provider/parity/discovery suite and the full cross-platform CI.
Summary
/v1/modelsand retain same-named custom provider configurations.Canonical-preset evidence
GET /v1/modelscontract and the key-scoped OpenAI-shaped model listContributor affiliation: @theQuert submits this contribution on behalf of Apertis / STIMA AI LLC.
Safety and scope
openai-chatadapter; no new auth flow or provider credential is added.Verification
bun test tests/apertis-provider.test.ts tests/provider-registry-parity.test.ts tests/provider-model-discovery-contract.test.ts— 56 passedbun run typecheckbun run privacy:scanbun run test— 6,293 passed, 4 skippedcd gui && bun test tests— 437 passedcd gui && bunx --bun eslint .cd gui && bun run buildcd docs-site && bun install --frozen-lockfile && bun run build— 146 pagesbun run lintinvokes the system Node ESLint launcher here, which cannot load the existing TypeScript config (.eslint/i18n-file-groups.ts); the same rules passed under Bun viabunx --bun eslint ..Checklist