Skip to content

fix(providers): add China Coding Plan baseUrl choice for Alibaba - #776

Merged
Wibias merged 5 commits into
lidge-jun:devfrom
Wibias:fix/756-alibaba-coding-china
Jul 31, 2026
Merged

fix(providers): add China Coding Plan baseUrl choice for Alibaba#776
Wibias merged 5 commits into
lidge-jun:devfrom
Wibias:fix/756-alibaba-coding-china

Conversation

@Wibias

@Wibias Wibias commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add Alibaba provider base URL choice for China Coding Plan endpoints.
  • Update provider registry parity tests.

Fixes #756

Test plan

  • �un run test (provider-registry-parity)

Security

  • none

Summary by CodeRabbit

  • New Features

    • Added Alibaba Coding Plan endpoint options for international and China mainland regions.
    • Added support for selecting a custom Alibaba endpoint URL.
  • Tests

    • Added coverage to verify Alibaba endpoint choices and custom URL overrides are available.

@Wibias Wibias mentioned this pull request Jul 30, 2026
4 tasks
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6f84ae2c-bbcd-429f-a323-698b3d44225b

📥 Commits

Reviewing files that changed from the base of the PR and between f2b61ee and 956d3b5.

📒 Files selected for processing (3)
  • src/providers/base-url-choices.ts
  • src/providers/registry.ts
  • tests/provider-registry-parity.test.ts

📝 Walkthrough

Walkthrough

Alibaba Coding Plan now provides international, China mainland, and custom base URL choices. The registry uses the international endpoint by default, and parity tests validate the available choices and override support.

Changes

Alibaba endpoint configuration

Layer / File(s) Summary
Define Alibaba endpoint presets
src/providers/base-url-choices.ts
Lines 42–51 add international and China mainland endpoint constants and export the corresponding choices with a custom URL option.
Wire endpoint choices into the provider registry
src/providers/registry.ts
Lines 8 and 973 import the presets, use the international endpoint as the default, and enable base URL overrides for Alibaba.
Validate Alibaba endpoint parity
tests/provider-registry-parity.test.ts
Lines 255–259 verify the three choices and their endpoints. Line 487 adds Alibaba to the permitted base URL override providers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: lidge-jun, ingwannu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding an Alibaba China Coding Plan base URL choice.
Linked Issues check ✅ Passed The changes add China and custom Alibaba base URL choices and registry parity coverage, meeting issue #756's objective.
Out of Scope Changes check ✅ Passed The registry, base URL presets, custom override, and parity tests are directly related to issue #756.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eef4064a03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/providers/base-url-choices.ts
Comment thread src/providers/registry.ts
Comment thread src/providers/registry.ts
@github-actions github-actions Bot added the bug Something isn't working label Jul 30, 2026
@Wibias

Wibias commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

[shipping-github] Merge-ready

  • \mergeStateStatus: CLEAN, base \dev, no \CHANGES_REQUESTED\
  • Cross-platform CI: all matrix jobs + enforce-target + label + react-doctor green
  • CodeRabbit: SUCCESS (rate-limited summary only; no blocking review state)

Wibias added 2 commits July 31, 2026 02:20
Add a custom baseUrl choice so dashboard saves do not rewrite non-preset Coding Plan endpoints to the international default.
Registry now includes the custom endpoint option alongside intl and china presets.
@Wibias

Wibias commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

Verdict: approve-comment

  • Usefulness: Fixes why can't use alibaba coding plan ? #756 dashboard China Coding Plan baseUrl rewrite.
  • Bugs: none for GUI scope. Known follow-up: ocx login alibaba still defaults international.
  • Security: preset URLs only.
  • Owner/maintainer reviews: none.
  • Bots: addressed / deferred.
  • Base / CI: green / pending noise only.
  • Gate: none for stated fix.

@Wibias

Wibias commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

Merging this.

Why it helps: China Coding Plan users can pick the mainland DashScope endpoint (or keep a custom URL) instead of being stuck on the international default.

@Wibias
Wibias merged commit e03bf35 into lidge-jun:dev Jul 31, 2026
9 checks passed
@Wibias
Wibias deleted the fix/756-alibaba-coding-china branch July 31, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant