feat(lxlweb): Display instance category in holding btns - #1627
Draft
jesperengstrom wants to merge 7 commits into
Draft
feat(lxlweb): Display instance category in holding btns#1627jesperengstrom wants to merge 7 commits into
jesperengstrom wants to merge 7 commits into
Conversation
jesperengstrom
changed the title
Contributor
|
Very promising! On the work level I think we should be able to group more categories under Book and E-book. Same logic that is used in the hit list. |
jesperengstrom
force-pushed
the
feat-display-instance-type-holding-btns
branch
from
June 11, 2026 12:43
5cd9ef4 to
23c9e7b
Compare
Contributor
Author
|
Pushed some improvements. Now all tests are failing for some reason. I did not manage to group more categories however. What the select type str does in the cards is a bit of a mystery to me. For the panel, we also need to place every instance in a "bucket" individually. That poses a problem since an OnlineResource is only an Ebook if there are other Ebooks, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves
Trying out instance category instead of type to group holdings into buttons and tabs in holdings panel.
Sometimes neat:
Sometimes a bit messy:
the key used for the types is a 'select slug' from the category
@id, this can be done now because book got the fake id_bookin another pr. This is also used for the url so that is is not language dependent.Let's discuss on design meeting.
Summary of changes