Sru with transformers - #1788
Conversation
jannistsiroyannis
left a comment
jannistsiroyannis
left a comment
There was a problem hiding this comment.
The indentation got a little weird, is it a tabs/spaces thing?
There's a few commented out code blocks that could be removed, and the run-local script should perhaps not be checked in, it assumes a certain directory which wont be the case for everyone.
Otherwise, LGTM (after handling the merge conflicts)!
|
Thx, I'll fix ;) |
There was a problem hiding this comment.
See comment about recordSchema. There have been a lot of changes to sru since this was branched off so it needs some careful rebasing to fix conflicts/not break some newer stuff: https://github.com/libris/librisxl/commits/develop/sru/src/main/java/whelk/sru/servlet
Otherwise LGTM!
| try { | ||
| String CqlQueryString = getParameter(parameters, "query"); | ||
| String CqlQueryString = parameters.get("query")[0]; | ||
| format = parameters.get("recordSchema")[0]; |
There was a problem hiding this comment.
recordSchema is afaik not a required parameter so this would NPE
3 participants
The sru transformer is a bit clumsy and requires maybe a rework.