fix: remove WAN link-local firewall exception#1265
Merged
Conversation
ilario
reviewed
Jul 18, 2026
| wan.setup_interface('eth0', {}) | ||
|
|
||
| assert.is.equal('eth0', uci:get('network', 'wan', 'device')) | ||
| assert.is_nil(uci:get('firewall', 'lime_allow_wan_all_link_local')) |
Member
There was a problem hiding this comment.
There is no need to test if this rule is effectively gone. This looks like an AI quirk.
Contributor
Author
There was a problem hiding this comment.
Removed the unnecessary regression test in 05460de. The PR now only removes the WAN link-local firewall exception.
Member
ilario
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I removed the
lime_allow_wan_all_link_localfirewall rule fromlime-proto-wan, so configuring a WAN interface no longer opens every service to IPv6 link-local peers on that interface.I also added a focused regression test that keeps the WAN device setup intact while checking that the firewall exception is absent.
Validation
I ran:
luac5.1 -p packages/lime-proto-wan/files/usr/lib/lua/lime/proto/wan.lua packages/lime-proto-wan/tests/test_wan.luawan.setup_interface(passes on this change and fails onmasterbecausemasterstill modifies the firewall)luacheck packages/lime-proto-wan/files/usr/lib/lua/lime/proto/wan.lua --no-unused --globals wanluacheck packages/lime-proto-wan/tests/test_wan.lua --globals describe it before_each after_each stub assertgit diff --checkThe full
./run_testssuite is deferred to CI because the local Docker socket is not accessible.Fixes #1241