enable CONFIG_{ACPI, PCI} for x86 - #138
Open
jakecorrenti wants to merge 1 commit into
Open
Conversation
jakecorrenti
requested review from
MatiasVara,
slp and
tylerfanelli
as code owners
August 6, 2026 14:35
jakecorrenti
marked this pull request as draft
August 6, 2026 14:36
Enable PCI and ACPI in the x86 kernel so that we can add support for them in libkrun and eventully support additional firmware options. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
jakecorrenti
marked this pull request as ready for review
August 6, 2026 15:29
jakecorrenti
changed the title
slp
reviewed
Aug 24, 2026
| CONFIG_LEGACY_VSYSCALL_XONLY=y | ||
| # CONFIG_LEGACY_VSYSCALL_NONE is not set | ||
| CONFIG_CMDLINE_BOOL=y | ||
| CONFIG_CMDLINE="reboot=k panic=-1 panic_print=0 nomodules console=hvc0 earlyprintk=hvc0 rootfstype=virtiofs rw no-kvmapf tsi_hijack init=/init.krun virtio_mmio.device=4K@0xd0000000:5 virtio_mmio.device=4K@0xd0001000:6 virtio_mmio.device=4K@0xd0002000:7 virtio_mmio.device=4K@0xd0003000:8 virtio_mmio.device=4K@0xd0004000:9 no-kvmclock" |
Collaborator
There was a problem hiding this comment.
Can we safely drop the manual virtio_mmio.device configuration?
Contributor
Author
There was a problem hiding this comment.
the ACPI PR in libkrun should do MMIO device discovery via the DSDT: https://github.com/libkrun/libkrun/pull/807/changes#diff-f5f077cd6d79a91eddba02f4bded81e632eaae588d7d9967864ea486c53882a5R36
Collaborator
There was a problem hiding this comment.
Would keeping the manual config generate a conflict for the ACPI PR? I think it'd be safer keeping it, at least for a while.
Contributor
Author
There was a problem hiding this comment.
I will double check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable PCI and ACPI in the kernel so that we can add support for them in libkrun and eventully support additional firmware options.