examples/c: rebuild BPF objects on header changes in CMake - #372
Merged
Conversation
Signed-off-by: Dhanya16 <dhanyabailoor@gmail.com>
Collaborator
|
Not entirely convinced this is the entire story, as I think it relies on a bug in the existing cmake plumbing. But it's probably better than the status quo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
bpf_object()supports optional headers inDEPENDS, butexamples/c/CMakeLists.txtonly passed the.bpf.csource. Touching a shared header (e.g.bootstrap.h) rebuilt userspace via CMake's normal C dependency scanning, but not the BPF object or skeleton.Change: Pass
${app_stem}.hintobpf_object()when that file exists.Follow-up to #371 (CMake path noted by @danielocfb ).
Before:
After: