Add AMBAR music dataset to Lenskit - #1187
Open
sushobhan2024 wants to merge 7 commits into
Open
Conversation
mdekstrand
requested changes
Aug 18, 2026
mdekstrand
left a comment
Member
There was a problem hiding this comment.
A few things this needs off the bat:
- tests (tagged with
@mark.realdata, see the Amazon and Steam load tests for examples). The tests should probably look at it indata/ambar. - adding to
data/convert.py. - adding to the data conversion CLI test script.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 90.37% 90.17% -0.21%
==========================================
Files 261 262 +1
Lines 17376 17417 +41
==========================================
+ Hits 15704 15705 +1
- Misses 1672 1712 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #1142
amber.pyto load data from its pathdescribe.pyso imported dataset can be described with the existing describe command