Skip to content

Add AMBAR music dataset to Lenskit - #1187

Open
sushobhan2024 wants to merge 7 commits into
lenskit:mainfrom
sushobhan2024:feature/ambar
Open

Add AMBAR music dataset to Lenskit#1187
sushobhan2024 wants to merge 7 commits into
lenskit:mainfrom
sushobhan2024:feature/ambar

Conversation

@sushobhan2024

@sushobhan2024 sushobhan2024 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

issue #1142

  • Added amber.py to load data from its path
  • Updated the describe.py so imported dataset can be described with the existing describe command

@sushobhan2024 sushobhan2024 self-assigned this Aug 18, 2026

@mdekstrand mdekstrand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things this needs off the bat:

  • tests (tagged with @mark.realdata, see the Amazon and Steam load tests for examples). The tests should probably look at it in data/ambar.
  • adding to data/convert.py.
  • adding to the data conversion CLI test script.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.43902% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (928f7eb) to head (d9cc10c).

Files with missing lines Patch % Lines
src/lenskit/data/sources/ambar.py 0.00% 36 Missing ⚠️
src/lenskit/cli/data/describe.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
- Coverage   90.37%   90.17%   -0.21%     
==========================================
  Files         261      262       +1     
  Lines       17376    17417      +41     
==========================================
+ Hits        15704    15705       +1     
- Misses       1672     1712      +40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants