Show the degree on the homepage, and stop printing one month twice - #50
Merged
Conversation
The homepage education list is sorted newest first and sliced to three, and the degree is the oldest entry by six years, so the section rendered three certificates and no degree. Entries can now be flagged as a degree and are pinned ahead of the rest. dateRange() printed a start and end inside the same month as "May 2022 - May 2022", which reads as a broken template. It prints the month once instead. The Encode.club entry ran Aug 2017 to Jul 2022, five years before the programme is recorded anywhere else. It now matches the tenure already given for the same organisation on the CV, Jun 2022 to Dec 2022. Also drops the second "See all projects" link, which sat on a section that already renders every app, and a commented-out list left in the education page. Test plan: - [x] make lint - [x] make build, 82 pages, 1758 internal links, none broken - [x] built HTML: no month range repeats itself - [x] built HTML: the homepage education section carries the degree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small correctness fixes on the homepage and the education page.
What changed
degreeflag and flagged entries are pinned ahead of the rest.dateRange()printed "May 2022 - May 2022" for an entry that starts and ends in the same month. It now prints the month once.APPS, and the identical link appears again further down the page.src/pages/education/index.astro.Test plan
make lintmake build: 82 pages, 1758 internal links, none brokendist/index.htmlcarries the degree in the education section