fix: use controlled settings menu by lawvs · Pull Request #38 · lawvs/eagle-plugin-mini-map

lawvs · 2026-07-14T06:23:41Z

Summary

replace the settings <details> disclosure with a native non-modal <dialog popover="auto">
anchor the panel to the settings trigger with CSS Anchor Positioning
rely on the browser for light dismiss, Escape handling, and focus restoration
keep the trigger visible while the popover is open and preserve existing settings behavior

Requires a modern Eagle Chromium runtime with Popover API and CSS Anchor Positioning support. No legacy fallback is included.

pnpm test (71 tests)
pnpm type-check
pnpm lint:check
pnpm format:check
pnpm build
Chrome interaction check: inside click, outside click, Escape/focus restoration, and anchor alignment

lawvs force-pushed the fix/settings-dialog-popover branch from caeef51 to 415d7fb Compare July 14, 2026 06:39

lawvs changed the title ~~fix: use native popover for settings menu~~ fix: use controlled settings menu Jul 14, 2026

lawvs force-pushed the fix/settings-dialog-popover branch 2 times, most recently from 6c53085 to 58d42f4 Compare July 14, 2026 06:53

fix: use controlled settings menu

de33704

lawvs force-pushed the fix/settings-dialog-popover branch 9 times, most recently from 05f84d8 to 5fb2c6a Compare July 14, 2026 10:11

fix: resolve Eagle theme on startup

e6b32b3

lawvs force-pushed the fix/settings-dialog-popover branch from 5fb2c6a to e6b32b3 Compare July 14, 2026 10:19

lawvs merged commit e948f72 into main Jul 14, 2026
1 check passed

lawvs deleted the fix/settings-dialog-popover branch July 14, 2026 10:24