Skip to content

fix: Remove dead __BUILTINS__ constant #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 2 commits into from
Jul 17, 2026
Merged

fix: Remove dead __BUILTINS__ constant #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
472278d
chore: Remove dead __BUILTINS__ constant
jsonbailey Jul 16, 2026
461e621
docs: Reference SDK-2696 on the ldclient.util logger comment
jsonbailey Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ldclient/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

__LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF)

__BUILTINS__ = ["key", "ip", "country", "email", "firstName", "lastName", "avatar", "name", "anonymous"]

"""Settings."""
start_wait = 5

Expand Down
2 changes: 0 additions & 2 deletions ldclient/impl/evaluator_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

__LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF)

__BUILTINS__ = ["key", "secondary", "ip", "country", "email", "firstName", "lastName", "avatar", "name", "anonymous"]


# EvalResult is used internally to hold the EvaluationDetail result of an evaluation along with
# other side effects that are not exposed to the application, such as events generated by
Expand Down
5 changes: 2 additions & 3 deletions ldclient/impl/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@ def timedelta_millis(delta: timedelta) -> float:
return delta / timedelta(milliseconds=1)


log = logging.getLogger('ldclient.util') # historical logger name
# historical logger name; cleaning up the SDK's logger names is tracked in SDK-2696
log = logging.getLogger('ldclient.util')


__LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF)

__BUILTINS__ = ["key", "ip", "country", "email", "firstName", "lastName", "avatar", "name", "anonymous"]

__BASE_TYPES__ = (str, float, int, bool)

# Maximum length for SDK keys
Expand Down
Loading