Skip to content

ci(spec-sync): scope the 504 timeout remediation per endpoint in the wiring prompt - #130

Merged
tian-lan-landing merged 2 commits into
mainfrom
ci/spec-sync-504-remediation
Jul 24, 2026
Merged

ci(spec-sync): scope the 504 timeout remediation per endpoint in the wiring prompt#130
tian-lan-landing merged 2 commits into
mainfrom
ci/spec-sync-504-remediation

Conversation

@tian-lan-landing

Copy link
Copy Markdown
Collaborator

Follow-up to the Copilot finding on #129: a wired `build_schema` reused `raise_if_sync_timeout`, whose message was hardcoded to `parse_jobs`/`extract_jobs` — so a build-schema 504 pointed users at the wrong async resource.

The code fix lands on the #129 branch (parameterize `raise_if_sync_timeout` with a required `jobs_resource`, pass the correct route at every call site). This PR is the pipeline half: the V2 wiring prompt now tells the AI to pass the endpoint's own `jobs_resource` (and extend the helper if it lacks per-endpoint support), so future regenerations don't reintroduce the wrong remediation.

Prompt-only change; no SDK surface touched.

…r endpoint

The prompt said "route a 504 through raise_if_sync_timeout" without noting the
helper's message was parse/extract-specific, so a wired build_schema inherited a
504 hint pointing at the wrong async resource. Instruct the AI to pass the
endpoint's own `jobs_resource` (extending the helper if needed) so future
regenerations name the correct *_jobs route.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 24, 2026 10:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the spec-sync AI wiring prompt to ensure endpoint-specific async-job guidance for HTTP 504 errors.

Changes:

  • Requires jobs_resource when invoking raise_if_sync_timeout.
  • Directs the AI to extend the helper when needed.

Comment thread .github/workflows/spec-sync.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 10:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@tian-lan-landing
tian-lan-landing merged commit 6027ba1 into main Jul 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants