Skip to content

Prevent data loss when downloading pangenomes - #17

Merged
JeanMainguy merged 3 commits into
mainfrom
fix_download_overwrite
Aug 6, 2026
Merged

Prevent data loss when downloading pangenomes#17
JeanMainguy merged 3 commits into
mainfrom
fix_download_overwrite

Conversation

@JeanMainguy

@JeanMainguy JeanMainguy commented Aug 6, 2026

Copy link
Copy Markdown
Member

Previously, re-running --download on an output directory containing modified pangenome files (e.g. files annotated with ppanggolin metadata) could delete these files when the MD5 checksum did not match the API version. If the subsequent download failed, the original file was lost.

Changes:

  • Download files to a temporary file first, then replace the destination only after successful checksum validation.
  • Keep existing files when the checksum differs unless --force is explicitly used.
  • Update logs to better distinguish checksum mismatches from corrupted files and clarify the action taken.

@JeanMainguy
JeanMainguy merged commit 69470c2 into main Aug 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant