Animate and haptically signal updated location counts - #192
Merged
Conversation
kyleve
commented
Aug 5, 2026
| // A task belongs to the card surface rather than the tab container: it | ||
| // is cancelled while another tab or a pushed destination covers these | ||
| // numbers, then re-runs when the user can see them again. | ||
| .task(id: report.ranking.primary) { |
Owner
Author
There was a problem hiding this comment.
Posted by an AI agent on kve's behalf.
Reviewer note: this task placement is the load-bearing visibility boundary. It must remain on the primary-card surface (not the surrounding NavigationStack or TabView) so hidden report updates do not consume the saved baseline before the numbers are visible again.
kyleve
commented
Aug 5, 2026
| preferences.setLastSeenLocationDayCounts(currentCounts, in: year) | ||
| lastSeenCounts = currentCounts | ||
| } | ||
| if shouldProvideFeedback { |
Owner
Author
There was a problem hiding this comment.
Lets ensure this only happens for increases, not just changes.
kyleve
commented
Aug 5, 2026
| // is cancelled while another tab or a pushed destination covers these | ||
| // numbers, then re-runs when the user can see them again. | ||
| .task(id: report.ranking.primary) { | ||
| dayCountPresentation.reveal(report.ranking.primary, in: report.selectedYear) |
Owner
Author
There was a problem hiding this comment.
Do we need to gate this on if we're visible as well?
kyleve
enabled auto-merge (squash)
August 5, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design notes
The reconciliation task is attached to the card surface and keyed by its counts, year, and explicit visibility. Switching tabs, pushing a destination, or presenting the Resolve sheet leaves the saved baseline untouched; returning to unobscured cards reconciles against the latest report. Multiple increased cards intentionally produce one coordinated haptic event.
Testing
./swiftformat --lint./test --all(1,629 tests passed before the focused review commits)./test WhereUITests(350 tests passed after review fixes)./test --snapshots(33 tests passed after review fixes; references unchanged)git diff --check