Collect various fixes - #111
Merged
Merged
Conversation
This reverts commit 7f0b319. Running `brew upgrade` can take quite a while now, just to do something like replacing a Firefox version. This was a workaround in its origin, and we will avoid it if we can.
kulp
marked this pull request as ready for review
August 14, 2026 11:41
The state encoding in tenyr.v used explicit width for the state values, which were pruned significantly in 6a4d284, at which point the explicit width became too wide. Leave the width unspecified so it is inferred.
The TENYR language is self-hosted: `enable_language(TENYR)` uses `find_program` for the tas assembler (in build/src) at configure time, but `tas` is only built at build time by add_subdirectory(src), which runs later. A clean `cmake -DBUILD_EXAMPLES=ON` (or `-DTESTING=ON`) therefore failed at enable_language with "Could not find CMAKE_TENYR_COMPILER ... tas". Add a configure-time bootstrap: when TENYR is needed and build/src/tas is absent, configure and build tas/tld/tsim into build/src in a throwaway _bootstrap directory, copy the binaries to the path find_program searches, and remove the bootstrap directory. Subsequent reconfigures skip the bootstrap because the tools are already present. A single clean `cmake -S . -B build -DTESTING=ON` now configures, builds, and passes `ctest`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MR collects minor fixes or improvements that were found in the course of other development. Commits should be reviewed individually, since they will have little or no relation to each other.