feat: support label selectors for list operations

[ystkfujii]

Overview

This PR adds label selector support to storage list operations.

Label selector support for GeneratedNetworkPolicy and other generated or aggregated resources will be addressed in the following issue:

• Add label selector support for generated and aggregated resources #363

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 68d61869-c4dd-4d69-ac60-288198e821b4

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[matthyx]

Thanks for this — the pagination + label/field selector matching logic looks correct, and the new TestStorageImpl_GetList_LabelSelectorWithPagination test does a good job exercising filtering across multiple pages of the underlying store.

A couple of things before this is ready to merge:

• The PR is still marked draft, and the description leaves an open question about whether GeneratedNetworkPolicy and other generated/aggregated resources belong in this PR or a follow-up. That should be resolved (and the PR marked ready) before merging.
• The branch is currently behind main — please rebase/update before merge.
• Left one minor nit inline about code duplication between the two fetch branches.

No functional blockers found in the diff itself — holding off on approval only because of the draft status and the branch being behind base. Happy to approve once those are addressed.

[ystkfujii]

@matthyx

Thank you for the quick review!
I missed your review and force-pushed before I noticed it, which made the diff harder to follow 😅
Sorry about that.

When you have time, could you please take another look?

[matthyx]

Looks good now — thanks for the update.

• The duplication between the two fetch branches is gone; GetListWithConn now runs a single unified loop, and normalizeSelectionPredicate centralizes the nil-safety/GetAttrs check (fails fast with a clear error instead of silently dropping items).
• The scope question is resolved: aggregated resources (GeneratedNetworkPolicy, config-scan/vulnerability summaries) explicitly force Label/Field to Everything() before paging their source objects, with a TODO + link to the follow-up (#363) rather than silently misapplying the selector.
• Pagination logic re-checked and still correct against the test.

Only remaining nit: the branch shows as behind main — worth updating before merge, but not a blocker from a code standpoint. Approving.