fix: bump kubescape/storage to v0.0.301 to resolve CRD schema drift - #404
Conversation
Fixes kubescape#403 Signed-off-by: Lalit Kishore <lr_be24@thapar.edu>
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates resource identity lookups to use related-resource metadata labels. It updates the related test fixtures and increases the versions of two direct Go dependencies. ChangesRelated resource label handling
Dependency updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI is failing due to build errors in after bumping to : The metadata keys in were updated/relocated in . Please update to use the new constant names. |
d583463 to
c486920
Compare
…ild failures Signed-off-by: Lalit Kishore <lr_be24@thapar.edu>
c486920 to
a900a1c
Compare
|
@matthyx thanks for your time , now I have resolved conflicts |
matthyx
left a comment
There was a problem hiding this comment.
LGTM! Code has been updated to use the new RelatedKindMetadataKey, RelatedNameMetadataKey, and RelatedNamespaceMetadataKey constants from storage v0.0.301. All CI checks are green.
Description
Fixes #403
Overview
This PR fixes #403
Signed Commits
This PR updates the
github.com/kubescape/storagedependency fromv0.0.239tov0.0.301to match the rest of the fleet (kubescape, kubevuln, node-agent).Current Behavior: The
operatoris ~60 releases behind the sharedstoragelibrary. While there are no active bugs for the CRDs it currently reads (WorkloadConfigurationScan, etc.), if it were to read other CRDs likeNetworkNeighborhoodtoday, it would silently drop newly introduced fields (likeipAddresses) due to outdated Go struct bindings.Future Behavior: By bumping the dependency, the
operator's schema definitions are now fully synchronized with the rest of the fleet, preventing latent bugs or silent schema drift.Additional Information
Here are the real output logs from applying the fix:
How to Test
go test ./...) to verify that the upgraded library models do not break the operator's unmarshaling logic.operatorbuilds properly and all existing workflows pass.Related issues/PRs:
Checklist before requesting a review
Summary by CodeRabbit
Bug Fixes
Chores