Repair links to the removed authentication-resources API reference pages - #57414
Open
abhinav-phi wants to merge 1 commit into
Open
Repair links to the removed authentication-resources API reference pages#57414abhinav-phi wants to merge 1 commit into
abhinav-phi wants to merge 1 commit into
Conversation
The v1.36 switch of the Kubernetes API reference to the gen-apidocs markdown backend did not emit pages for create-only resources, so the authentication.k8s.io and authorization.k8s.io group pages disappeared along with the legacy authentication-resources URLs (kubernetes/website kubernetes#57313). Sixteen links across ten English docs pages still pointed at those dead URLs. Repoint the links at the pages that document the same API today: - TokenReview and SelfSubjectReview -> their definitions pages under /docs/reference/kubernetes-api/definitions/ - ServiceAccount -> /docs/reference/kubernetes-api/core/service-account-v1/ - CertificateSigningRequest -> /docs/reference/kubernetes-api/certificates/certificate-signing-request-v1/ - TokenRequest -> the TokenRequest API usage documentation (service-accounts-admin bound-token sections); the remaining mentions that only named the API inline now use a code span instead of a link - A historical blog post keeps its original text unchanged (it describes the state of that release) Signed-off-by: abhinav-phi <alpha9coder@gmail.com>
kubernetes-prow
Bot
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it
As of the v1.36 API reference migration (to the gen-apidocs markdown backend), the legacy
authentication-resourcesURLs were removed and the generator did not emit the authentication/authorization group pages. Sixteen links across ten English docs pages still pointed at the dead URLs — for example, service-accounts-admin #tokenrequest-api linksTokenRequestto a page that now redirects into the storage CSI docs (#57313).This PR repoints those links at the pages that document the same API today:
authentication-resources/...)token-review-v1//docs/reference/kubernetes-api/definitions/token-review-v1-authentication/self-subject-review-v1//docs/reference/kubernetes-api/definitions/self-subject-review-v1-authentication/service-account-v1//docs/reference/kubernetes-api/core/service-account-v1/certificate-signing-request-v1/(+ anchor variant)/docs/reference/kubernetes-api/certificates/certificate-signing-request-v1/token-request-v1//docs/reference/access-authn-authz/service-accounts-admin/#bound-service-account-token-volumeFor the three
TokenRequestmentions insideservice-accounts-admin.mditself (where linking to that same page's anchor would be self-referential), the links become inline code spans. A mention of the historical 1.22 blog post is left untouched.There is no TokenRequest definitions page on
maintoday (see the note below), which is why TokenRequest links go to the canonical usage documentation instead.Which issue(s) this PR fixes
Fixes #57313
Special notes for your reviewer
authentication/andauthorization/group directories return, and these links can be upgraded to the new per-resource pages if desired.grep -rn "authentication-resources" content/en/docs --include="*.md"returns 0 after this PR (was 16).Does this PR introduce a user-facing change?