Skip to content

Reduce integer code and mark it inlinable #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skitt wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −24
Open

Reduce integer code and mark it inlinable #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 20 additions & 24 deletions integer/integer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,60 +20,56 @@ import "math"

// IntMax returns the maximum of the params.
// Deprecated: for new code, use the max() builtin instead.
//
//go:fix inline
func IntMax(a, b int) int {
if b > a {
return b
}
return a
return max(a, b)
}

// IntMin returns the minimum of the params.
// Deprecated: for new code, use the min() builtin instead.
//
//go:fix inline
func IntMin(a, b int) int {
if b < a {
return b
}
return a
return min(a, b)
}

// Int32Max returns the maximum of the params.
// Deprecated: for new code, use the max() builtin instead.
//
//go:fix inline
func Int32Max(a, b int32) int32 {
if b > a {
return b
}
return a
return max(a, b)
}

// Int32Min returns the minimum of the params.
// Deprecated: for new code, use the min() builtin instead.
//
//go:fix inline
func Int32Min(a, b int32) int32 {
if b < a {
return b
}
return a
return min(a, b)
}

// Int64Max returns the maximum of the params.
// Deprecated: for new code, use the max() builtin instead.
//
//go:fix inline
func Int64Max(a, b int64) int64 {
if b > a {
return b
}
return a
return max(a, b)
}

// Int64Min returns the minimum of the params.
// Deprecated: for new code, use the min() builtin instead.
//
//go:fix inline
func Int64Min(a, b int64) int64 {
if b < a {
return b
}
return a
return min(a, b)
}

// RoundToInt32 rounds floats into integer numbers.
// Deprecated: use math.Round() and a cast directly.
//
//go:fix inline
func RoundToInt32(a float64) int32 {
return int32(math.Round(a))
}
Loading