Modernize golangci-lint config

.golangci.yml

@@ -2,33 +2,28 @@ version: "2"
 linters:
   default: standard
   enable:
+    - bodyclose
+    - prealloc
     - unparam
   settings:
     staticcheck:
       dot-import-whitelist:
         - fmt
         - github.com/onsi/ginkgo/v2
         - github.com/onsi/gomega
+  exclusions:
+    paths:
+      - generated.*\.go
+      - client
+      - vendor
 
 formatters:
   enable:
-    - gofmt
+    - gofumpt
     - goimports
-  settings:
-    gofmt:
-      rewrite-rules:
-        - pattern: 'interface{}'
-          replacement: 'any'
 
 issues:
   max-same-issues: 100
 
-  exclude-files:
-    - generated.*\\.go
-
-  exclude-dirs:
-    - client
-    - vendor
-
 run:
   timeout: 10m

pkg/evaluator/eval.go

@@ -132,7 +132,9 @@ func getProgramForRule(rule string) (cel.Program, error) {
 	}
 	env, err := cel.NewEnv(
 		cel.VariableDecls(
-			decls.NewVariable(defaultCELVar, types.DynType)))
+			decls.NewVariable(defaultCELVar, types.DynType),
+		),
+	)
 	if err != nil {
 		return nil, err
 	}

test/e2e/framework/crd.go

@@ -28,25 +28,26 @@ import (
 )
 
 func (f *Framework) EnsureCRD() GomegaAsyncAssertion {
-	return Eventually(func() error {
-		if err := f.kc.List(f.ctx, &api.RecommendationList{}); err != nil {
-			return fmt.Errorf("CRD Recommendation is not ready, Reason: %v", err)
-		}
-
-		if err := f.kc.List(f.ctx, &api.MaintenanceWindowList{}); err != nil {
-			return fmt.Errorf("CRD MaintainenceWindow is not ready, Reason: %v", err)
-		}
-
-		if err := f.kc.List(f.ctx, &api.ClusterMaintenanceWindowList{}); err != nil {
-			return fmt.Errorf("CRD ClusterMaintainenceWindow is not ready, Reason: %v", err)
-		}
-
-		if err := f.kc.List(f.ctx, &api.ApprovalPolicyList{}); err != nil {
-			return fmt.Errorf("CRD ApprovalPolicy is not ready, Reason: %v", err)
-		}
-
-		return nil
-	},
+	return Eventually(
+		func() error {
+			if err := f.kc.List(f.ctx, &api.RecommendationList{}); err != nil {
+				return fmt.Errorf("CRD Recommendation is not ready, Reason: %v", err)
+			}
+
+			if err := f.kc.List(f.ctx, &api.MaintenanceWindowList{}); err != nil {
+				return fmt.Errorf("CRD MaintainenceWindow is not ready, Reason: %v", err)
+			}
+
+			if err := f.kc.List(f.ctx, &api.ClusterMaintenanceWindowList{}); err != nil {
+				return fmt.Errorf("CRD ClusterMaintainenceWindow is not ready, Reason: %v", err)
+			}
+
+			if err := f.kc.List(f.ctx, &api.ApprovalPolicyList{}); err != nil {
+				return fmt.Errorf("CRD ApprovalPolicy is not ready, Reason: %v", err)
+			}
+
+			return nil
+		},
 		time.Minute*2,
 		time.Second*10,
 	)