fix: remove outdated Future Improvements section regarding embedding model - #230
Open
pratik-naik003 wants to merge 3 commits into
Open
fix: remove outdated Future Improvements section regarding embedding model#230pratik-naik003 wants to merge 3 commits into
pratik-naik003 wants to merge 3 commits into
Conversation
Signed-off-by: pratik naik <naikp0241@gmail.com>
Signed-off-by: pratik naik <naikp0241@gmail.com>
… model Signed-off-by: pratik naik <naikp0241@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229
In the Kubeflow Pipelines section of the
README.md, there was a "Future Improvements" paragraph suggesting that the embedding model should be extracted into a separate service. However, in the final Modern Infrastructure & CI/CD section, the README states that the ingestion pipeline was rewritten and theall-mpnet-base-v2model is now baked directly into a custom Docker image.This PR removes the outdated "Future Improvements" subsection to prevent conflicting architectural goals in the documentation.
My commits are signed off (
git commit -s)Testing
Manually verified that the outdated section has been removed from
README.mdand the document reads cohesively.