Skip to content

fix: inconsistent Milvus hostname default values in README - #228

Open
pratik-naik003 wants to merge 2 commits into
kubeflow:mainfrom
pratik-naik003:fix/issue-227-milvus-hostname
Open

fix: inconsistent Milvus hostname default values in README#228
pratik-naik003 wants to merge 2 commits into
kubeflow:mainfrom
pratik-naik003:fix/issue-227-milvus-hostname

Conversation

@pratik-naik003

Copy link
Copy Markdown

Fixes #227

There is a discrepancy in the default hostname provided for Milvus in the README.md file. In the Environment Variables table, it is my-release-milvus.docs-agent.svc.cluster.local, while in the Pipeline Parameters table it is milvus-standalone-final.docs-agent.svc.cluster.local. This PR unifies the default hostname across both tables to match the provided Helm installation instructions, preventing confusion for new users configuring the pipeline.

[x] My commits are signed off (git commit -s)

Testing

  • Unit tests
  • Integration tests
  • E2E tests
  • Manually tested (describe below)

Manually verified that the default values in both configuration tables now match my-release-milvus.docs-agent.svc.cluster.local.

Signed-off-by: pratik naik <naikp0241@gmail.com>
Signed-off-by: pratik naik <naikp0241@gmail.com>
@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign franciscojavierarceo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: inconsistent Milvus hostname default values in README

1 participant