[LOW] Pin CI actions and keep secrets off pull requests - #153
Open
OskarEichler wants to merge 1 commit into
Open
[LOW] Pin CI actions and keep secrets off pull requests#153OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutandruby/setup-rubyto the reviewed release commits.masterpushes.Security impact
This addresses two low-severity CI trust-boundary issues. A configured Coveralls token could otherwise reach unreviewed same-repository pull-request code, and mutable action references could change without review while running in the workflow's token context.
The latest public
masterrun showedCOVERALLS_REPO_TOKENunset, so the Coveralls path is preventative for future configuration. Fork pull requests do not receive repository secrets. This workflow does not publish the gem or hold RubyGems credentials.Verification
bundle exec rake— 220 examples, 0 failures; 15 files, no RuboCop offenses.bundle exec rake— 220 examples, 0 failures; 15 files, no RuboCop offenses.git diff --check.actions/checkoutv7.0.1 andruby/setup-rubyv1.321.0.Limitations
Breaking changes
None. Pull requests still run the same test matrix; only Coveralls submission is limited to trusted
masterpushes.