Skip to content

Load component dependencies directly - #152

Open
OskarEichler wants to merge 1 commit into
ku1ik:masterfrom
OskarEichler:songstats/rainbow-component-requires
Open

Load component dependencies directly#152
OskarEichler wants to merge 1 commit into
ku1ik:masterfrom
OskarEichler:songstats/rainbow-component-requires

Conversation

@OskarEichler

Copy link
Copy Markdown

The packaged component entry points are not self-contained:

  • require 'rainbow/color' raises because X11ColorNames has not been loaded.
  • require 'rainbow/null_presenter' can construct the class, but named-color dispatch raises because Color has not been loaded.

Require each direct dependency from the component that uses it. Normal require 'rainbow' behavior and load order remain unchanged.

Verification:

  • release/master fail both isolated-process component checks; this branch passes all four checks on Ruby 3.2.11 and 4.0.6
  • full suite: 220 examples / 0 failures on both Rubies
  • 15-file RuboCop run: 0 offenses on both Rubies
  • rebuilt 14-file gem passes the packaged component models

No API break; direct documented/package entry points become independently loadable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant