Validate unsupported and malformed color values - #147
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject unsupported color definitions and require RGB arrays to contain exactly three components instead of returning
nil, raising incidentalNoMethodError, or silently discarding extras.Reproduction
On current master,
Rainbow('x').color(nil)returns through anilcolor and fails later withNoMethodError;color([])and two-element arrays also raise incidental errors;[1, 2, 3, 4]silently ignores the fourth component. The documented contract accepts one color definition or exactly three RGB values.The symbol branch is extracted into a private class helper solely to keep the expanded validation within the repository's lint thresholds.
Verification
Breaking change
Undocumented invalid definitions now consistently raise
ArgumentError; surplus RGB components are no longer ignored. Valid documented definitions are unchanged.