feat: Arrow integration JSON reader and test suite - #109
Open
winding-lines wants to merge 1 commit into
Open
Conversation
winding-lines
changed the title
winding-lines
force-pushed
the
json-dep
branch
3 times, most recently
from
April 19, 2026 13:11
2b2ec14 to
2c51acd
Compare
Add marrow/integration.mojo with read_json_file() that parses Apache Arrow integration testing JSON files into Schema + List[RecordBatch]. Supports bool, int8/16/32/64, uint8/16/32/64, float32/64, utf8, list, fixed-size list, and struct column types via Python json interop. Add JSON fixtures under testing/integration/ (primitives, booleans, strings, lists, structs) and 16 tests in test_json_integration.mojo covering schema parsing, validity bitmaps, and element values for all supported types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks @winding-lines! We definitely need this. Let me review it. |
kszucs
reviewed
Apr 19, 2026
| pytest = ">=9.0.2,<10" | ||
| pytest-benchmark = ">=5.2.3,<6" | ||
| pytest-xdist = ">=3,<4" | ||
| json = { git = "https://github.com/ehsanmok/json.git", tag = "v0.1.2" } |
Owner
There was a problem hiding this comment.
Could we use the python json lib instead for integration testing? It is not performance critical but we need correctness.
kszucs
reviewed
Apr 19, 2026
Owner
There was a problem hiding this comment.
The integration testing is a little bit more involved, see https://github.com/apache/arrow-rs/blob/main/.github/workflows/integration.yml and https://github.com/apache/arrow/tree/main/dev/archery/archery/integration
Collaborator
Author
There was a problem hiding this comment.
Thanks, I realized I was missing the point of the exercise just wasn't sure where to look 🤣
Owner
|
We should close it in favor of the new integration testing suite now in main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add marrow/integration.mojo with read_json_file() that parses Apache Arrow integration testing JSON files into Schema + List[RecordBatch]. Supports bool, int8/16/32/64, uint8/16/32/64, float32/64, utf8, list, fixed-size list, and struct column types via Python json interop.
Add JSON fixtures under testing/integration/ (primitives, booleans, strings, lists, structs) and 16 tests in test_json_integration.mojo covering schema parsing, validity bitmaps, and element values for all supported types.