Make the Monaco package installable from npm - #432
Open
holodorum wants to merge 1 commit into
Open
Conversation
Its `file:` dependencies pointed at packages that are not published, so installing from the registry left a dangling link and broke `npm ls`. Vite inlines both at build time, so they belong in `devDependencies`. Also fixes the readme's package name, which 404'd, and the license, which claimed ISC. Documents the publishing steps, which existed nowhere, so the next release does not depend on remembering this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kson_org/monaco-editordeclared@kson/lsp-sharedandkson-language-serverasdependencies, byfile:path. Neither is published to npm, so afile:path that exists only on the publishing machine went to the registry. Installing from it produces a dangling symlink and a failingnpm ls:Vite inlines both into the bundle at build time, so they are build-time inputs rather than install-time requirements — the shipped
distnames no external module beyond themonaco-editorandreactpeers, and the bundled languageserver runs with neither package present on disk. Moving them to
devDependenciesleaves the package working exactly as before and stops npm directing consumers at packages that do not exist.Also fixed
The readme referenced
@kson/monaco-editorthroughout — the wrong scope — so both install commands 404'd and no import example resolved.The license claimed ISC while the project is Apache-2.0. Corrected, and the terms now ship: npm includes a
LICENSEfile whether or notfileslists it.