perf: compile regex patterns once instead of per-call in hot paths - #1098
Open
myukitty wants to merge 1 commit into
Open
perf: compile regex patterns once instead of per-call in hot paths#1098myukitty wants to merge 1 commit into
myukitty wants to merge 1 commit into
Conversation
Signed-off-by: myukitty <myukittyy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #826 by compiling regular expressions once and reusing them across invocations in hot paths:
internal/digest/digest.go(ValidateDigest):validSha256CompiledRegexinstead of compiling the static SHA256 validation pattern on every call.BenchmarkValidateDigest.internal/filters/resourceFilter.go(ResourceFilterOptions):compiledExclude,compiledInclude) andCompilePatterns() errormethod.ShouldIncludecompiles patterns once lazily on first invocation and reuses them across resource checks (e.g. iterating over namespaces/pods/functions/clusters).CompilePatternsandBenchmarkShouldInclude_Regex.internal/gitview/gitView.go(MatchPatternInCommitMessageORBranchName):MatchRegexpInCommitMessageORBranchNametaking a pre-compiled*regexp.Regexp.MatchPatternInCommitMessageORBranchNameto safely compile viaregexp.Compileand delegate without panicking.internal/jira/jira.go(FindJiraIssueKeys):dashDigitRegex.Fixes #826.
Validation
go test -v -run TestFiltersSuite ./internal/filters: PASSgo test -v -run TestGitViewTestSuite ./internal/gitview: PASSgo test -v ./internal/jira: PASSgo test -v -run "TestDigestTestSuite/TestValidateDigest" ./internal/digest: PASSgo test -bench=Benchmark ./internal/digest ./internal/filters: PASSgo vet ./...: PASS (clean)APPROVE, confidence 1.0)