Remove 'presentation' from version string - #179
Open
stweil wants to merge 1 commit into
Open
Conversation
Otherwise it is misinterpreted as a pre-release. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Author
|
This should fix the handling of https://www.wikidata.org/wiki/Q47007505. |
Owner
|
Can you say more about the specific example and how it fails? |
Author
|
It fails to accept valid releases: With increased logging, the reason for the failing releases is shown: The failing releases have names which start with "Kitodo.Presentation". This string includes "pre" which is interpreted as a pre-release, therefore 'unstable', although all these releases are normal stable releases. |
Author
|
@konstin, even with my patch, the script still fails, but with a different error ("Session lost (assertbotfailed)"): Do you have an idea what could cause this failure? |
Author
|
Note that this patch fixes 40 of 41 invalid releases, but there remains this "invalid" release: Here the conflict is caused by '3.0.0-beta.1' != '3.0.0-Beta.1'. Maybe such minor mismatches should be accepted. |
Owner
|
To solve this case, we should match with the project name, instead of replacing specific strings, which only handle this project. |
Author
|
"Presentation" can be part of any project name and included in their release strings, so this PR is not project specific. But of course there might be more strings in release name which include "pre" and which are not pre-releases. A complete run on all projects with debug output enabled would show all cases. |
Owner
|
I'd like to avoid maintaining a list of specific strings; Can we find a way to fix this misdetection by changing the string processing heuristics instead? |
Author
|
Instead of removing "presentation", we could remove any "pre" which is either followed by a letter or which follows a letter", because in these cases it is likely not an indication of a pre-release. |
Author
|
But do you have an idea why the script reports "Session lost (assertbotfailed), re-logging in" and finally fails? |
Owner
The code assumes a bot account to ensure that the bot gets logged in again after timing out, instead of running into API errors for anonymous users, that can be disabled by removing the bot assertion:
Can you explain why e.g. the existing name removal heuristic doesn't work? When changing the heuristics, we need to ensure that we have the broadest heuristic possible (for maintainability, to avoid having to change it again and again for mostly similar problems) and to make reasonable sure that there are no regressions where we break cases that used to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it is misinterpreted as a pre-release.