Skip to content

fix: do not re-download when zip exists or existing zip not malformed - #9

Draft
asimtahir-karakus-kd with Copilot wants to merge 4 commits into
masterfrom
copilot/fix-zip-download-logic
Draft

fix: do not re-download when zip exists or existing zip not malformed#9
asimtahir-karakus-kd with Copilot wants to merge 4 commits into
masterfrom
copilot/fix-zip-download-logic

Conversation

Copilot AI commented Apr 16, 2026

Copy link
Copy Markdown
  • Rebase and reword original commit to conventional commit format (single commit, no extra commits added)

@asimtahir-karakus-kd

Copy link
Copy Markdown
Collaborator

@copilot rename PR title in conventional commit format without use scope

Copilot AI commented Apr 17, 2026

Copy link
Copy Markdown
Author

@copilot rename PR title in conventional commit format without use scope

The PR title should be updated to: fix: do not re-download when zip exists or existing zip not malformed — this follows the conventional commit format (type: description) without a scope. I'm unable to rename the PR title directly via the tools available to me; please update it manually in the GitHub UI.

@asimtahir-karakus-kd asimtahir-karakus-kd changed the title Skip re-download of mainframe_xpublic.zip when valid copy exists fix: do not re-download when zip exists or existing zip not malformed Apr 17, 2026
Agent-Logs-Url: https://github.com/kocdigital/sf-cli-service/sessions/120c16ad-98d2-41ad-a960-dee4be89b443

Co-authored-by: asimtahir-karakus-kd <209095940+asimtahir-karakus-kd@users.noreply.github.com>
@asimtahir-karakus-kd
asimtahir-karakus-kd force-pushed the copilot/fix-zip-download-logic branch from 102d9d3 to 3176f5e Compare April 17, 2026 07:50
Comment thread lib/commands/serve/streempublic.js Outdated
Agent-Logs-Url: https://github.com/kocdigital/sf-cli-service/sessions/37e44107-be1c-4f26-a89f-78e86712df1e

Co-authored-by: asimtahir-karakus-kd <209095940+asimtahir-karakus-kd@users.noreply.github.com>
@asimtahir-karakus-kd

Copy link
Copy Markdown
Collaborator

@copilot use async/await fs methods instead of sync ones

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Author

@copilot use async/await fs methods instead of sync ones

Done in the latest commit. Replaced fs.existsSync with a fileExists async helper using fs.promises.access, and fs.unlinkSync with await fs.promises.unlink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not re-download when zip exist or existing zip not malformed

2 participants