[wip] Arrange about CChainParams. - #27
Open
kobake wants to merge 6 commits into
Open
Conversation
kobake
force-pushed
the
arrange-chain-params
branch
from
May 18, 2017 12:19
f32c8de to
8630d4c
Compare
kobake
force-pushed
the
arrange-chain-params
branch
from
May 18, 2017 12:47
8630d4c to
435d539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master の wip 解消用。一旦 master-tmp へのマージが完了したら master-tmp の内容で master のほうに force push する。
対応内容:CMainParams, CTestNetParams, CRegTestParams のグローバル変数を定義しているが、それのコンストラクタが何故か呼ばれないことがあり、それの対症療法として変数への参照を適当に定義した(ものすごく気持ち悪い)
現在の状況:試行錯誤したコミットを wip として記録しているのであとでちゃんと squash する。tmp って付いてるコミットは不要(検証中のビルド時間を短くするためにテストコードビルドを省くコミットを入れた)なので rebase で消す予定。
一応現段階では問題は解決したが、気持ち悪い対症療法は嫌なのでもう少し調査を進めて根本的な解決を探りたい。理想をいえばそれが解決してから squash とマージを行う。調査の結果、どうにもならなかったら対症療法のまま進めてしまう。