Fix newton negligible derivative - #240
Closed
mubasharameen485-cloud wants to merge 4 commits into
Closed
Conversation
Add SvdSettings with a configurable max_sweeps field, defaulting to 60 to preserve existing behaviour. Matrix::svd() now delegates to Matrix::svd_with_settings() with the default settings. Fixes kmolan#156
Compare |dfx| against EPSILON * |fx| instead of an exact-zero check, so a derivative like 1e-300 is correctly rejected as singular instead of producing a meaningless huge step. Closes kmolan#206
Owner
|
@mubasharameen485-cloud I am rejecting this PR. I will remind you again: You must close your previous ticket first, only then begin on the next one: #235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206