Skip to content

fix: update lastExecution on actual execution - #1086

Open
Abhi-05-git wants to merge 1 commit into
kelektiv:mainfrom
Abhi-05-git:fix-1048-last-execution
Open

fix: update lastExecution on actual execution#1086
Abhi-05-git wants to merge 1 commit into
kelektiv:mainfrom
Abhi-05-git:fix-1048-last-execution

Conversation

@Abhi-05-git

@Abhi-05-git Abhi-05-git commented Aug 31, 2026

Copy link
Copy Markdown

Description

Updates lastExecution when the callback actually begins execution, so skipped ticks caused by waitForCompletion do not incorrectly advance the execution timestamp.

Related Issue

Fixes #1048.

Motivation and Context

When waitForCompletion is enabled and a previous callback is still running, a scheduled tick can be skipped. lastExecution should represent the last actual callback execution rather than a skipped tick.

How Has This Been Tested?

Added a regression test covering waitForCompletion and lastExecution behavior.

  • npm test -- --runInBand — 162 tests passed
  • npm run build — passed

Screenshots (if appropriate)

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lastDate()/lastExecution does not reflect the last execution of the registered callback(s)

1 participant