feat(protocol): report taproot support in Features - #120
Open
BitHighlander wants to merge 1 commit into
Open
Conversation
Adds Features.supports_taproot (field 27) so a host can detect P2TR capability directly rather than inferring it from a firmware version string, which breaks whenever the feature is retargeted to a different release. Field number and wording match the same field in #112, so the two do not conflict when that lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a single field to
Features:Why
keepkey-firmwaresets this infsm_msg_common.hso a host can detect P2TRcapability directly instead of inferring it from a firmware version string,
which breaks whenever the feature is retargeted to a different release.
Why this is separate from #112
#112 carries the same field, and this PR keeps field number 27 and the exact
wording so the two agree and do not conflict when #112 lands.
It is split out because #112 is the full 7.15 proto surface (hive, near, ripple,
solana, zcash — 3,071 lines). Pinning that into the 7.14.3 bitcoin-only release
branch pulls in structured EIP-712 and Solana LUT fields that have no
.optionsentries in that tree, so nanopb emits
pb_callback_tfor them and both the ARMand emulator builds fail with:
7.14.3 needs
supports_taprootand nothing else from this repo — no source fileon that branch references any other field #112 adds.
Checks
protocparsesmessages.protocleanmaster(Featureshas 1-18, 21-26)