fix: remove host model warnings from profile selectors - #3521
Conversation
GitHub Actions
Inactive
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (19)
💤 Files with no reviewable changes (6)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change removes host-catalog model advisories from saved-profile selectors. Profiles remain selectable, health indicators remain visible, and executor model selection remains authoritative. Unit tests, desktop/mobile E2E tests, specifications, translations, and documentation reflect the new behavior. ChangesProfile selector advisory removal
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to Profile selectors now omit host-model advisories while preserving health indicators and executor model behavior. The covered selection and execution flows indicate no remaining merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant ProfileSelector
participant KanbanTaskDialog
participant MockAgentSession
ProfileSelector->>KanbanTaskDialog: Select saved executor-only profile
KanbanTaskDialog->>MockAgentSession: Submit task with saved model
MockAgentSession-->>KanbanTaskDialog: Complete session with requested model
KanbanTaskDialog-->>ProfileSelector: Show selected profile without host advisory
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 6 files. (7 skipped: 7 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit hops past warnings bright Comment |
|
Claude finished @carlosflorencio's task in 8m 50s —— View job Code Review Complete
Verdict: Ready to merge. No blockers found. Two minor suggestions posted as inline comments. |
|
| Filename | Overview |
|---|---|
| apps/web/components/task-create-dialog-options.tsx | Removes host-model warning rendering and catalog subscription, but also drops capability revalidation needed by some shared selector consumers. |
| apps/web/components/task-create-dialog-options.test.tsx | Adds broad absence assertions and verifies rendering of already-present capability warnings, but does not cover asynchronous capability settlement after a pending probe. |
| apps/web/e2e/tests/settings/profile-model-selection-helpers.ts | Adds a well-guarded shared flow proving an executor-only model launches successfully and persists across reload. |
| apps/web/e2e/tests/settings/no-silent-model-fallback.spec.ts | Replaces desktop advisory checks with warning-free keyboard selection and successful-launch coverage. |
| apps/web/e2e/tests/settings/mobile-no-silent-model-fallback.spec.ts | Replaces touch advisory interaction with direct row selection and adds mobile launch and layout coverage. |
| docs/specs/agents/requirements/no-silent-model-fallback.md | Defines selector warning placement and explicitly preserves health indicators, editor diagnostics, runtime warnings, and saved configuration. |
| docs/public/agents-and-profiles.md | Documents that host catalogs are editing hints and profile selectors no longer display model-difference warnings. |
Reviews (1): Last reviewed commit: "fix: remove host model warnings from pro..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Cloudflare Pages docs previewBuilt from docs commit Stable PR alias: https://docs-pr-3521.landing-87j.pages.dev/docs |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
FindingsSuggestion (recommended, doesn't block)
Summary
Verdict: Ready to merge The frontend changes are well-scoped and correct. The two new test suites cover the right axes: parameterized absence assertions across every catalog state (missing, exact, unique variation, multiple variations, empty, pending), preserved capability health indicators, profile value immutability, and label stability when the host catalog changes. The new Spec and documentation updates are accurate and consistent with the implementation. The plan scope (frontend-only, no Go changes) is respected — the backend divergence visible in a broad |
GitHub Actions
Inactive
1 participant
Tip
PR walkthrough: Open the visual walkthrough
Host model catalogs do not prove which models an executor can use, so profile selectors no longer show host-model advisories. Agent health warnings, profile-editor diagnostics, and persisted runtime fallback warnings remain available.
Validation
i18n:check, andi18n:ratchetpassed.Exact commands and results are recorded in
docs/plans/profile-selector-model-warnings/task-01-remove-host-model-advisories.md.Checklist
apps/web/), I have added or updated Playwright e2e tests inapps/web/e2e/and verified them withmake test-e2e.docs/public/**and updated them or noted why no docs change is needed.Screenshots