feat(queue): move automation toggles to session scope - #3465
Conversation
|
Too many files changed for review (214 files, 100 file limit). Bypass the limit by tagging |
|
Important Review skippedToo many files! This PR contains 197 files, which is 47 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (197)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @Fclem's task in 7m 53s —— View job FindingsSuggestion (recommended, doesn't block)
Summary
Verdict: Ready with suggestions The backend is well-structured. Identity-boundary semantics ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abcf424ab5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
The new UX with the two buttons looks better 👍 I see you refactored a lot of strings as well, let me check the other changes. |
|
Yes this is incorrect, will extract that in another PR |
|
Thanks for the contribution. I pushed
The branch is current with |
57b5ec1 to
3208c18
Compare
…toggles-p-dxs # Conflicts: # docs/decisions/INDEX.md # docs/specs/ui/README.md
…y' into feature/move-queue-toggles-p-dxs
|
Let me know after you split the PR so i can review again. |
…toggles-p-dxs # Conflicts: # apps/backend/internal/agent/runtime/lifecycle/executor_sprites_operations.go # apps/backend/internal/backendapp/orchestrator.go # apps/backend/internal/orchestrator/service.go # apps/backend/internal/orchestrator/task_operations.go # apps/backend/internal/system/settings/store.go # docs/decisions/INDEX.md
…toggles-p-dxs # Conflicts: # apps/backend/internal/orchestrator/event_handlers_agent.go # apps/backend/internal/orchestrator/queue_send_now.go # apps/backend/internal/orchestrator/queue_send_now_test.go
…emote-20260908 # Conflicts: # apps/backend/internal/orchestrator/event_handlers_agent.go # apps/backend/internal/orchestrator/queue_send_now.go # apps/backend/internal/orchestrator/task_operations.go
|
Thanks for the contribution. I synced this branch with current |
…toggles-p-dxs # Conflicts: # apps/backend/internal/orchestrator/event_handlers_agent.go # apps/backend/internal/orchestrator/queue_send_now.go # apps/backend/internal/orchestrator/task_operations.go
…re/move-queue-toggles-p-dxs
Tip
PR walkthrough: Open the visual walkthrough
The Auto-run control was taking way too much space for its purpose, so queue automation controls now sit as compact pills beside the queued count while their explanatory behavior remains discoverable through tooltips. Auto-merge is scoped per session and retains its supplementary compatibility guidance.
Important Changes
IMP Move queue toggles per session.Validation
pnpm --filter @kandev/web test -- --run components/task/chat/queued-ghost-panel-header.test.tsxpnpm exec prettier --check components/task/chat/queued-ghost-panel-header.tsx components/task/chat/queued-ghost-panel-header.test.tsxgit diff --checkChecklist
apps/web/), I have added or updated Playwright e2e tests inapps/web/e2e/and verified them withmake test-e2e.docs/public/**and updated them or noted why no docs change is needed.Screenshots