S0A-3 follow-up: fix hosted CI — move numpy/pandas/openpyxl to base deps - #5
Merged
Conversation
The hosted "Unit Tests (hosted)" job (introduced in PR #4) fails on a clean ubuntu-latest runner: it installs only ".[dev,gui]", but core hardware-free modules import scientific libs that were wrongly filed under the [hardware] extra: * fluid/legacy.py -> import numpy (pump-stroke arithmetic) * imaging.py -> import pandas (PFS log DataFrame) + DataFrame.to_excel(...xlsx) -> openpyxl So `pip install -e .` (or ".[dev,gui]") produced a package whose fluid/imaging modules — and every test that imports them — raised ModuleNotFoundError, which is exactly what broke the hosted gate. Move numpy (keeping the <2 ABI cap), pandas, and openpyxl into the base `dependencies`. All three are wheel-only, so the base install stays wheel-only. Verified: a full `python -m unittest discover` passes (370 tests, no hang) in a clean venv with only ".[dev,gui]" installed and QT_QPA_PLATFORM=offscreen. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hosted "Unit Tests (hosted)" job (introduced in PR #4) fails on a clean ubuntu-latest runner: it installs only ".[dev,gui]", but core hardware-free modules import scientific libs that were wrongly filed under the [hardware] extra:
DataFrame.to_excel(...xlsx) -> openpyxl
So
pip install -e .(or ".[dev,gui]") produced a package whose fluid/imaging modules — and every test that imports them — raised ModuleNotFoundError, which is exactly what broke the hosted gate.Move numpy (keeping the <2 ABI cap), pandas, and openpyxl into the base
dependencies. All three are wheel-only, so the base install stays wheel-only. Verified: a fullpython -m unittest discoverpasses (370 tests, no hang) in a clean venv with only ".[dev,gui]" installed and QT_QPA_PLATFORM=offscreen.