Feature FullAutoS0A - #3
Merged
Merged
Conversation
The new per-subsystem `enabled` flag dropped deselected subsystems from the compiled Run Sequence, but several paths still assumed all three keys were present: - frontend_cli.do_load_protocol: guard fluid/img `_assign_protocol` with .get() (mirroring the illu branch) so loading a design with a subsystem deselected no longer raises KeyError. - builder.create_protocol: return step lists derived from the compiled, pruned protocol instead of the raw self.steps, so callers see exactly what was written to disk (no orphaned 'wait for signal' entries). - builder.build_protocol: raise ValueError when every subsystem is deselected instead of validating and running as a silent no-op; broaden the enabled check to also treat the string "false" as disabled for hand-edited YAML. - CHANGELOG: document the subsystem-selection feature under [Unreleased]. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S0A pack