feat: owner revoke/update + linux CI - #5
Merged
Conversation
Owner management over the mesh: - Add OwnerRevoke and OwnerUpdate ControlMessage variants - Add owner_revoke_preimage and owner_update_preimage wire functions - Add update_label method to EnrollmentStore - Handle OwnerRevoke and OwnerUpdate in agent (verify signature, apply) - Remove = node forgets that owner, Update = changes label GitHub Actions CI: - Enable CI workflow for push to rework/unify branch and tags - Enable CI for pull requests to rework/unify - Produces mymesh-linux-x86_64 binary artifact ALPN mymesh-enroll/1: - Add documentation comment about wire protocol expectations Also fixes pre-existing clippy warnings to ensure CI passes. Co-authored-by: jtwolfe <jtwolfe@users.noreply.github.com>
jtwolfe
marked this pull request as ready for review
August 14, 2026 03:02
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the REWORK-UNIFY effort on jtwolfe/MyMesh. This slice adds:
Owner Management Over Mesh
Honor owner add/remove/update from carrier over the mesh (not HTTP 17878):
Implementation details:
OwnerRevokeandOwnerUpdatevariants toControlMessagein the protocolowner_revoke_preimageandowner_update_preimagewire functions for signature verificationupdate_labelmethod toEnrollmentStorecan_driveGitHub Actions CI
Enabled the existing (disabled) CI workflow:
rework/unifybranch andv*tagsrework/unifymymesh-linux-x86_64ALPN mymesh-enroll/1 Documentation
Added documentation comment in
enroll.rsexplaining the wire protocol expectations for themymesh-enroll/1ALPN. The currentEnrollRequestmessage (ticket + person_public_key_hex + person_id + mesh_name) matches the DESIGN protocol.Clippy Fixes
Fixed pre-existing clippy warnings to ensure CI passes with
-D warnings:mymesh-net: derivable_impls, dead_code, large_enum_variantmymesh-terminal: redundant_closuremymesh-session: borrowed_box, for_kv_map, while_let_loopmymesh-core: manual_repeat_nmymesh-cli: print_literal, format_in_format_args, derivable_impls, collapsible_if, if_same_then_else, min_maxTesting
cargo build --workspace✓cargo fmt --all -- --check✓cargo clippy --workspace --all-targets -- -D warnings✓cargo test --workspace✓Not Included
mymesh linkormymesh enroll