fix RFC 2544 benchmarking range to 198.18.0.0/15 - #21
Open
cpu wants to merge 2 commits into
Open
Conversation
RFC 2544 does list 192.18.0.0 as the lower range of the assigned network addresses, but this was a typo and should have been 198.18.0.0 to match the upper end (198.19.255.255). See this errata: https://errata.rfc-editor.org/eid423/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 2544 does list
192.18.0.0as the lower range of the assigned network addresses, but this was a typo and should have been198.18.0.0. See this errata: https://errata.rfc-editor.org/eid423/The
169.254.0.0/16network was also listed as ado-not-query-addresstwice, once on L58 and then again on L61 with an RFC 3927 citation. I removed the first and left the second.Beyond these two fixes, it also looks like the config here might be missing some entries that I think at least Boulder is rejecting via the IANA special-purpose registry CSV data (https://github.com/letsencrypt/boulder/tree/main/iana). Presumably these networks are also in the prod Unbound configs (?):
2002::/16(RFC 7526)3fff::/20IPv6 documentation space (RFC 9637)5f00::/16(RFC 9602)I haven't included those here but maybe it would be worth doing that if there's been drift between unboundtest & the prod configs.