Skip to content

Use chrono in syncron socket API - #231

Merged
mrabine merged 9 commits into
mainfrom
use-chrono-in-sync-socket-api
Aug 29, 2026
Merged

Use chrono in syncron socket API#231
mrabine merged 9 commits into
mainfrom
use-chrono-in-sync-socket-api

Conversation

@mrabine

@mrabine mrabine commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production

codacy-production Bot commented Aug 29, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 6 critical

Alerts:
⚠ 6 issues (≤ 0 issues of at least minor severity)

Results:
6 new issues

Category Results
Security 6 critical

View in Codacy

🟢 Metrics 269 duplication

Metric Results
Duplication 269

View in Codacy

🟢 Coverage 97.55% diff coverage · +0.08% coverage variation

Metric Results
Coverage variation +0.08% coverage variation
Diff coverage 97.55% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (807c194) 13794 13430 97.36%
Head commit (4aaa4be) 13888 (+94) 13533 (+103) 97.44% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#231) 163 159 97.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.54601% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.47%. Comparing base (807c194) to head (4aaa4be).

Files with missing lines Patch % Lines
crypto/include/join/tls.hpp 96.87% 2 Missing ⚠️
crypto/include/join/tls_stream.hpp 50.00% 1 Missing ⚠️
fabric/include/join/resolver.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   97.38%   97.47%   +0.08%     
==========================================
  Files         124      124              
  Lines       12961    13053      +92     
==========================================
+ Hits        12622    12723     +101     
+ Misses        339      330       -9     
Flag Coverage Δ
unittests 97.47% <97.54%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented Aug 29, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 33277611821

Coverage increased (+0.08%) to 97.444%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: 4 uncovered changes across 3 files (159 of 163 lines covered, 97.55%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
crypto/include/join/tls.hpp 64 62 96.88%
crypto/include/join/tls_stream.hpp 2 1 50.0%
fabric/include/join/resolver.hpp 4 3 75.0%
Total (9 files) 163 159 97.55%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
core/src/reactor.cpp 1 98.07%

Coverage Stats

Coverage Status
Relevant Lines: 13888
Covered Lines: 13533
Line Coverage: 97.44%
Coverage Strength: 91063.34 hits per line

💛 - Coveralls

@mrabine
mrabine merged commit 7733f2d into main Aug 29, 2026
13 of 14 checks passed
@mrabine
mrabine deleted the use-chrono-in-sync-socket-api branch August 29, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants