Skip to content

Add proactor based async socket - #227

Merged
mrabine merged 2 commits into
mainfrom
add-proactor-based-async-socket
Aug 26, 2026
Merged

Add proactor based async socket#227
mrabine merged 2 commits into
mainfrom
add-proactor-based-async-socket

Conversation

@mrabine

@mrabine mrabine commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production

codacy-production Bot commented Aug 26, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 47 complexity · 14 duplication

Metric Results
Complexity 47
Duplication 14

View in Codacy

🟢 Coverage 99.60% diff coverage · +0.02% coverage variation

Metric Results
Coverage variation +0.02% coverage variation
Diff coverage 99.60% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce57964) 13631 13247 97.18%
Head commit (b487005) 13710 (+79) 13326 (+79) 97.20% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#227) 249 248 99.60%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.58159% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.21%. Comparing base (ce57964) to head (b487005).

Files with missing lines Patch % Lines
core/include/join/async_socket.hpp 99.32% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   97.19%   97.21%   +0.01%     
==========================================
  Files         122      123       +1     
  Lines       12804    12876      +72     
==========================================
+ Hits        12445    12517      +72     
  Misses        359      359              
Flag Coverage Δ
unittests 97.21% <99.58%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32969838316

Coverage increased (+0.02%) to 97.199%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (248 of 249 lines covered, 99.6%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
core/include/join/async_socket.hpp 158 157 99.37%
Total (5 files) 249 248 99.6%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13710
Covered Lines: 13326
Line Coverage: 97.2%
Coverage Strength: 91945.67 hits per line

💛 - Coveralls

@mrabine
mrabine merged commit 33de676 into main Aug 26, 2026
15 checks passed
@mrabine
mrabine deleted the add-proactor-based-async-socket branch August 26, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants